Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ergw_sbi_client #411

Merged
merged 11 commits into from
Jul 26, 2021
Merged

Add ergw_sbi_client #411

merged 11 commits into from
Jul 26, 2021

Conversation

vkatsuba
Copy link
Contributor

  • Create new application ergw_sbi_client
  • Include ergw_sbi_client into ergw
  • Update ergw for validation of ergw_sbi_client
  • Include ergw_sbi_client into ergw_core

@vkatsuba vkatsuba force-pushed the feature/ergw_sbi_client branch 3 times, most recently from d2f14c0 to 8dda24c Compare June 30, 2021 15:56
@vkatsuba vkatsuba requested review from RoadRunnr and a team and removed request for RoadRunnr June 30, 2021 16:01
@mgumz
Copy link
Contributor

mgumz commented Jul 6, 2021

@vkatsuba what parts of the functionality is missing?

@mgumz mgumz added the feature 🚀 Feature Request label Jul 6, 2021
@vkatsuba
Copy link
Contributor Author

vkatsuba commented Jul 6, 2021 •
edited
Loading

@vkatsuba what parts of the functionality is missing?

Missed the part for generate JSON body request for send it by API. It is still not clear how to correctly form the JSON, from what data, and how we can use response inside of erGW. But so far as I know, the @RoadRunnr was start implement something for it or in separate PR or so. So, I suppose he have more info about this, cuz I was get know about it only 5 min ago.

@RoadRunnr RoadRunnr force-pushed the feature/ergw_sbi_client branch 7 times, most recently from 8844955 to c21589b Compare July 12, 2021 16:04
@RoadRunnr RoadRunnr marked this pull request as ready for review July 12, 2021 16:05
@RoadRunnr
Copy link
Member

limitations, restrictions, requirements and deviations from the API specification:

  • only the fqdn return type of the API is supported
  • UPF nodes that can be selected need to be configured in the upf_nodes / entries section with a "connect":true setting
  • UPGs need to run with the upf specification release 16 setting
  • FQDNs in the upf_nodes / entries section and the API return have to match verbatim, no expansions will be performed on them all location information (CGI, SAI, LAI, ...) are optional (even when then API specification has some of them as mandatory), this might no change for the final version, as we do not receive those values in some settings
  • QoS-Information is a structured type instead of a string (we might want to keep this for the final version and change the API specification accordingly)

@RoadRunnr
SBI:: use structed types
bc76349 
Replace plain binaries with structured types.
@vkatsuba vkatsuba merged commit 2794795 into master Jul 26, 2021
@vkatsuba vkatsuba deleted the feature/ergw_sbi_client branch July 26, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fholzhauser fholzhauser fholzhauser approved these changes

Assignees
No one assigned
Labels
feature 🚀 Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkatsuba @mgumz @RoadRunnr @fholzhauser